Fix transaction title rendering for AuthenticationConfigs
ClosedPublic
Actions

Authored by amckinley on Jul 17 2019, 7:32 PM.

Details

Reviewers

epriestley

Commits

rP97c16997561b: Fix transaction title rendering for AuthenticationConfigs

Summary

I was poking around in PhabricatorAuthProviderViewController and noticed that none of the subclass-specific rendering was working. Figured out that no one ever calls PhabricatorAuthProviderConfigTransaction->setProvider(), so instead of adding all those calls, just pull the provider out of the config object.

Test Plan

Before:

Screen Shot 2019-07-17 at 12.28.51 PM.png (541×479 px, 46 KB)

After:

Screen Shot 2019-07-17 at 12.29.00 PM.png (565×579 px, 52 KB)

Diff Detail

Repository

rP Phabricator

Branch

master

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 23139
Build 31776: Run Core Tests
Build 31775: arc lint + arc unit

Event Timeline

amckinley created this revision.Jul 17 2019, 7:32 PM

Harbormaster completed remote builds in B23139: Diff 49271.Jul 17 2019, 7:34 PM

amckinley requested review of this revision.Jul 17 2019, 7:34 PM

Herald added a subscriber: Korvin. · View Herald TranscriptJul 17 2019, 7:34 PM

This seems very likely to always work properly when we expect it to.

It's possible for a transaction to not have an object but it looks like getObject() throws in this case rather than returning null so we should get a helpful exception even if something bizarre is afoot on some pathway here.

This revision is now accepted and ready to land.Jul 17 2019, 7:39 PM

Closed by commit rP97c16997561b: Fix transaction title rendering for AuthenticationConfigs (authored by amckinley). · Explain WhyJul 17 2019, 7:41 PM

This revision was automatically updated to reflect the committed changes.

amckinley added a commit: rP97c16997561b: Fix transaction title rendering for AuthenticationConfigs.