Page MenuHomePhabricator

Fix transaction title rendering for AuthenticationConfigs
ClosedPublic

Authored by amckinley on Jul 17 2019, 7:32 PM.
Tags
None
Referenced Files
F12838290: D20655.id49271.diff
Thu, Mar 28, 6:03 PM
Unknown Object (File)
Thu, Mar 14, 5:31 PM
Unknown Object (File)
Tue, Mar 5, 4:12 AM
Unknown Object (File)
Feb 8 2024, 4:04 AM
Unknown Object (File)
Feb 3 2024, 10:54 PM
Unknown Object (File)
Jan 27 2024, 9:55 AM
Unknown Object (File)
Jan 16 2024, 5:03 AM
Unknown Object (File)
Dec 21 2023, 6:46 AM
Subscribers

Details

Summary

I was poking around in PhabricatorAuthProviderViewController and noticed that none of the subclass-specific rendering was working. Figured out that no one ever calls PhabricatorAuthProviderConfigTransaction->setProvider(), so instead of adding all those calls, just pull the provider out of the config object.

Test Plan

Before:

Screen Shot 2019-07-17 at 12.28.51 PM.png (541×479 px, 46 KB)

After:
Screen Shot 2019-07-17 at 12.29.00 PM.png (565×579 px, 52 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This seems very likely to always work properly when we expect it to.

It's possible for a transaction to not have an object but it looks like getObject() throws in this case rather than returning null so we should get a helpful exception even if something bizarre is afoot on some pathway here.

This revision is now accepted and ready to land.Jul 17 2019, 7:39 PM