Page MenuHomePhabricator

Fix a bad call to "writeInfo()" in "bin/phd stop" with no PHABRICATOR_INSTANCE defined
ClosedPublic

Authored by epriestley on Jul 12 2019, 3:41 PM.
Tags
None
Referenced Files
F15382373: D20649.diff
Fri, Mar 14, 12:05 PM
Unknown Object (File)
Feb 18 2025, 8:08 AM
Unknown Object (File)
Feb 10 2025, 3:48 AM
Unknown Object (File)
Feb 10 2025, 3:48 AM
Unknown Object (File)
Feb 10 2025, 3:48 AM
Unknown Object (File)
Feb 2 2025, 3:48 AM
Unknown Object (File)
Jan 29 2025, 3:00 AM
Unknown Object (File)
Jan 28 2025, 5:19 AM
Subscribers
None

Details

Summary
Test Plan
  • Purged PHABRICATOR_INSTANCE from my environment. In a Phacility development environment, it comes from loading services/.
  • Ran bin/phd stop with all daemons already stopped.
    • Before: bad call.
    • After: helpful error.
  • Ran some other bin/phd start, bin/phd status, etc., to kick the tires.
  • Grepped for remaining writeInfo() calls (found none).

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable