Paths

Table of Contentst

Differential D20649

Fix a bad call to "writeInfo()" in "bin/phd stop" with no PHABRICATOR_INSTANCE defined
ClosedPublic
Actions

Authored by epriestley on Jul 12 2019, 3:41 PM.

Tags

None

Referenced Files

	F13050932: D20649.id49262.diff
	Fri, Apr 19, 3:16 AM

	F13050931: D20649.id49261.diff
	Fri, Apr 19, 3:16 AM

	F13050930: D20649.id.diff
	Fri, Apr 19, 3:16 AM

	Unknown Object (File)
	Thu, Apr 11, 9:08 AM

	Unknown Object (File)
	Thu, Apr 11, 4:25 AM

	Unknown Object (File)
	Fri, Apr 5, 8:21 AM

	Unknown Object (File)
	Sun, Mar 31, 12:22 AM

	Unknown Object (File)
	Sat, Mar 30, 8:24 AM

Subscribers

None

Details

Reviewers

Commits

rPd2935fd7bdc2: Fix a bad call to "writeInfo()" in "bin/phd stop" with no PHABRICATOR_INSTANCE…

Summary

See https://discourse.phabricator-community.org/t/phd-status-calls-to-undefined-method-when-theres-no-instance/2918. This call should be logInfo().

Test Plan

Purged PHABRICATOR_INSTANCE from my environment. In a Phacility development environment, it comes from loading services/.
Ran bin/phd stop with all daemons already stopped.
- Before: bad call.
- After: helpful error.
Ran some other bin/phd start, bin/phd status, etc., to kick the tires.
Grepped for remaining writeInfo() calls (found none).

Diff Detail

Repository

Branch

phd1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 23129
Build 31759: Run Core Tests
Build 31758: arc lint + arc unit

Event Timeline

epriestley created this revision.Jul 12 2019, 3:41 PM

Harbormaster completed remote builds in B23129: Diff 49261.Jul 12 2019, 3:43 PM

epriestley requested review of this revision.Jul 12 2019, 3:43 PM

amckinley accepted this revision.Jul 12 2019, 4:14 PM

This revision is now accepted and ready to land.Jul 12 2019, 4:14 PM

Closed by commit rPd2935fd7bdc2: Fix a bad call to "writeInfo()" in "bin/phd stop" with no PHABRICATOR_INSTANCE… (authored by epriestley). · Explain WhyJul 12 2019, 4:15 PM

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rPd2935fd7bdc2: Fix a bad call to "writeInfo()" in "bin/phd stop" with no PHABRICATOR_INSTANCE….

Revision Contents
Changeset List

Path

Size

src/

applications/

daemon/

management/

PhabricatorDaemonManagementStatusWorkflow.php

2 lines

Diff 49261

src/applications/daemon/management/PhabricatorDaemonManagementStatusWorkflow.php

Loading...