Page MenuHomePhabricator

Fix a bad call to "writeInfo()" in "bin/phd stop" with no PHABRICATOR_INSTANCE defined
ClosedPublic

Authored by epriestley on Jul 12 2019, 3:41 PM.
Tags
None
Referenced Files
F14081938: D20649.diff
Fri, Nov 22, 10:19 PM
Unknown Object (File)
Thu, Oct 24, 4:54 PM
Unknown Object (File)
Oct 21 2024, 7:49 PM
Unknown Object (File)
Oct 17 2024, 6:10 AM
Unknown Object (File)
Sep 26 2024, 11:45 PM
Unknown Object (File)
Sep 23 2024, 1:57 AM
Unknown Object (File)
Aug 25 2024, 5:46 AM
Unknown Object (File)
Aug 25 2024, 4:09 AM
Subscribers
None

Details

Summary
Test Plan
  • Purged PHABRICATOR_INSTANCE from my environment. In a Phacility development environment, it comes from loading services/.
  • Ran bin/phd stop with all daemons already stopped.
    • Before: bad call.
    • After: helpful error.
  • Ran some other bin/phd start, bin/phd status, etc., to kick the tires.
  • Grepped for remaining writeInfo() calls (found none).

Diff Detail

Repository
rP Phabricator
Branch
phd1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 23129
Build 31759: Run Core Tests
Build 31758: arc lint + arc unit