Page MenuHomePhabricator

Fix "add more metadata" fatal in Pholio
ClosedPublic

Authored by epriestley on Jul 11 2019, 9:40 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Apr 29, 1:27 AM
Unknown Object (File)
Sat, Apr 27, 5:18 PM
Unknown Object (File)
Sat, Apr 27, 4:28 PM
Unknown Object (File)
Sat, Apr 27, 9:29 AM
Unknown Object (File)
Thu, Apr 25, 1:12 AM
Unknown Object (File)
Fri, Apr 19, 3:18 PM
Unknown Object (File)
Fri, Apr 19, 3:16 AM
Unknown Object (File)
Fri, Apr 19, 3:16 AM
Subscribers
None

Details

Summary

Ref T13332. This fix isn't terribly satisfying, but resolves the issue: this behavior may attempt to build HTML blocks with metadata after Javascript footer rendering has started. Use hsprintf() to flatten the markup earlier.

Test Plan

Put a T123 reference in the description of a Pholio image, then loaded a mock.

Diff Detail

Repository
rP Phabricator
Branch
pholio1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 23125
Build 31753: Run Core Tests
Build 31752: arc lint + arc unit