Page MenuHomePhabricator

Fix "add more metadata" fatal in Pholio
ClosedPublic

Authored by epriestley on Jul 11 2019, 9:40 PM.
Tags
None
Referenced Files
F18049101: D20647.id.diff
Sun, Aug 3, 3:22 PM
F18036323: D20647.diff
Sun, Aug 3, 1:52 AM
F18022534: D20647.diff
Sat, Aug 2, 8:35 PM
F17985383: D20647.diff
Fri, Aug 1, 8:50 PM
F17712027: D20647.diff
Thu, Jul 17, 9:22 AM
Unknown Object (File)
Jun 26 2025, 6:18 AM
Unknown Object (File)
May 28 2025, 2:50 PM
Unknown Object (File)
May 27 2025, 8:25 PM
Subscribers
None

Details

Summary

Ref T13332. This fix isn't terribly satisfying, but resolves the issue: this behavior may attempt to build HTML blocks with metadata after Javascript footer rendering has started. Use hsprintf() to flatten the markup earlier.

Test Plan

Put a T123 reference in the description of a Pholio image, then loaded a mock.

Diff Detail

Repository
rP Phabricator
Branch
pholio1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 23125
Build 31753: Run Core Tests
Build 31752: arc lint + arc unit