Page MenuHomePhabricator

Fix "add more metadata" fatal in Pholio
ClosedPublic

Authored by epriestley on Jul 11 2019, 9:40 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Mar 27, 12:49 AM
Unknown Object (File)
Thu, Mar 14, 5:28 PM
Unknown Object (File)
Mon, Mar 4, 11:05 PM
Unknown Object (File)
Feb 24 2024, 4:40 PM
Unknown Object (File)
Feb 22 2024, 9:02 AM
Unknown Object (File)
Feb 3 2024, 10:52 PM
Unknown Object (File)
Jan 25 2024, 10:41 AM
Unknown Object (File)
Jan 25 2024, 2:07 AM
Subscribers
None

Details

Summary

Ref T13332. This fix isn't terribly satisfying, but resolves the issue: this behavior may attempt to build HTML blocks with metadata after Javascript footer rendering has started. Use hsprintf() to flatten the markup earlier.

Test Plan

Put a T123 reference in the description of a Pholio image, then loaded a mock.

Diff Detail

Repository
rP Phabricator
Branch
pholio1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 23125
Build 31753: Run Core Tests
Build 31752: arc lint + arc unit