Page MenuHomePhabricator

Fix "add more metadata" fatal in Pholio
ClosedPublic

Authored by epriestley on Jul 11 2019, 9:40 PM.
Tags
None
Referenced Files
F15183944: D20647.id49259.diff
Thu, Feb 20, 11:01 AM
Unknown Object (File)
Tue, Feb 18, 4:28 AM
Unknown Object (File)
Mon, Feb 17, 10:24 PM
Unknown Object (File)
Fri, Feb 14, 9:36 PM
Unknown Object (File)
Thu, Feb 13, 2:44 AM
Unknown Object (File)
Mon, Feb 10, 3:50 AM
Unknown Object (File)
Mon, Feb 10, 3:50 AM
Unknown Object (File)
Mon, Feb 10, 3:50 AM
Subscribers
None

Details

Summary

Ref T13332. This fix isn't terribly satisfying, but resolves the issue: this behavior may attempt to build HTML blocks with metadata after Javascript footer rendering has started. Use hsprintf() to flatten the markup earlier.

Test Plan

Put a T123 reference in the description of a Pholio image, then loaded a mock.

Diff Detail

Repository
rP Phabricator
Branch
pholio1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 23125
Build 31753: Run Core Tests
Build 31752: arc lint + arc unit