Page MenuHomePhabricator

Fix double-close on dialogs leading to Javascript console error
ClosedPublic

Authored by epriestley on Jul 3 2019, 3:19 PM.
Tags
None
Referenced Files
F18791254: D20640.id49235.diff
Thu, Oct 16, 8:08 AM
F18790350: D20640.diff
Wed, Oct 15, 1:43 PM
F18779866: D20640.diff
Sat, Oct 11, 3:39 PM
F18768048: D20640.id49240.diff
Wed, Oct 8, 1:30 AM
F18599963: D20640.diff
Sep 13 2025, 8:41 AM
F18567119: D20640.id.diff
Sep 9 2025, 3:31 PM
F18096266: D20640.id49235.diff
Aug 8 2025, 5:45 AM
F18047302: D20640.id.diff
Aug 3 2025, 11:39 AM
Subscribers
None

Details

Summary

Ref T13302. The "Close/Cancel" button is currently running two copies of the "dismiss dialog" code, since it's techncally a link with a valid HREF attribute.

An alternate formulation of this is perhaps if (JX.Stratcom.pass()) { return; } ("let other handlers react to this event; if something kills it, stop processing"), but pass() is inherently someone spooky/fragile so try to get away without it.

Test Plan

Opened the Javascript console, clicked "Edit Task" on a workboard, clicked "Close" on the dialog. Before: event was double-handled leading to a JS error in the console. After: dialog closes uneventfully.

Diff Detail

Repository
rP Phabricator
Branch
double-close
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 23104
Build 31722: Run Core Tests
Build 31721: arc lint + arc unit