Page MenuHomePhabricator

Fix double-close on dialogs leading to Javascript console error
ClosedPublic

Authored by epriestley on Jul 3 2019, 3:19 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Mar 14, 5:26 PM
Unknown Object (File)
Feb 26 2024, 10:00 AM
Unknown Object (File)
Feb 19 2024, 1:01 PM
Unknown Object (File)
Feb 3 2024, 10:49 PM
Unknown Object (File)
Feb 1 2024, 8:24 PM
Unknown Object (File)
Jan 26 2024, 10:39 AM
Unknown Object (File)
Jan 25 2024, 10:10 AM
Unknown Object (File)
Jan 25 2024, 2:06 AM
Subscribers
None

Details

Summary

Ref T13302. The "Close/Cancel" button is currently running two copies of the "dismiss dialog" code, since it's techncally a link with a valid HREF attribute.

An alternate formulation of this is perhaps if (JX.Stratcom.pass()) { return; } ("let other handlers react to this event; if something kills it, stop processing"), but pass() is inherently someone spooky/fragile so try to get away without it.

Test Plan

Opened the Javascript console, clicked "Edit Task" on a workboard, clicked "Close" on the dialog. Before: event was double-handled leading to a JS error in the console. After: dialog closes uneventfully.

Diff Detail

Repository
rP Phabricator
Branch
double-close
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 23104
Build 31722: Run Core Tests
Build 31721: arc lint + arc unit