Differential D20625

Lightly modernize OAuth server application view pages
ClosedPublic
Actions

Authored by epriestley on Jun 29 2019, 3:36 PM.

Details

Reviewers

amckinley

Maniphest Tasks

T13330: OAuth Application object view pages have some out-of-date UI elements

Commits

rPd22f6d219b0b: Lightly modernize OAuth server application view pages

Summary

Depends on D20624. Fixes T13330. The OAuth client pages are using some out-of-date rendering conventions; update them to modern conventions.

Test Plan

Viewed a page, saw a modern header layout + curtain:

Screen Shot 2019-06-29 at 8.34.57 AM.png (1×1 px, 241 KB)

Diff Detail

Repository

rP Phabricator

Branch

oauth2

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 23075
Build 31676: Run Core Tests
Build 31675: arc lint + arc unit

Event Timeline

epriestley created this revision.Jun 29 2019, 3:36 PM

Harbormaster completed remote builds in B23075: Diff 49206.Jun 29 2019, 3:37 PM

epriestley requested review of this revision.Jun 29 2019, 3:37 PM

amckinley accepted this revision.Jun 29 2019, 9:25 PM

This revision is now accepted and ready to land.Jun 29 2019, 9:25 PM

Closed by commit rPd22f6d219b0b: Lightly modernize OAuth server application view pages (authored by epriestley). · Explain WhyJul 2 2019, 12:15 PM

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rPd22f6d219b0b: Lightly modernize OAuth server application view pages.

Revision Contents
Changeset List

Path

Size

src/

applications/

oauthserver/

controller/

client/

PhabricatorOAuthClientViewController.php

95 lines

Diff 49206

View Options

src/applications/oauthserver/controller/client/PhabricatorOAuthClientViewController.php

Lightly modernize OAuth server application view pagesClosedPublicActions