Page MenuHomePhabricator

Require commit identities when editing commits to resolve an issue with audit actions not applying properly
ClosedPublic

Authored by epriestley on Jun 24 2019, 4:26 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Mar 22, 4:51 PM
Unknown Object (File)
Feb 13 2024, 8:00 AM
Unknown Object (File)
Feb 11 2024, 12:10 AM
Unknown Object (File)
Jan 31 2024, 3:10 AM
Unknown Object (File)
Jan 22 2024, 3:40 PM
Unknown Object (File)
Jan 16 2024, 12:14 AM
Unknown Object (File)
Jan 15 2024, 1:26 PM
Unknown Object (File)
Jan 15 2024, 12:52 PM
Subscribers
None

Details

Summary

See https://discourse.phabricator-community.org/t/cannot-audit-a-git-commit/2848. In D20581, I made some audit behavior dependent upon identities, but the actual edit flow doesn't load them. This can cause us to raise an "attach identities first" exception in the bowels of the edit workflow and trigger unexpected behavior at top level.

Load identities when editing a commit so that the transaction flows have access to identity information and can use it to figure out if a user is an author, etc.

Test Plan
  • As an auditor, applied an "Accept Commit" action to an open audit after D20581.
  • Before patch: accept no-ops internally since the preconditions throw.
  • After patch: accept works properly.

Diff Detail

Repository
rP Phabricator
Branch
audit1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 23034
Build 31622: Run Core Tests
Build 31621: arc lint + arc unit