Page MenuHomePhabricator
Differential D20599

Update "phabricator/" for "topological" API changes
ClosedPublic
Actions

Authored by epriestley on Jun 20 2019, 7:15 PM.
Tags
None
Referenced Files
F22304480: D20599.diff
Sun, Aug 30, 10:30 PM
Unknown Object (File)
Mon, Aug 24, 8:25 PM
Unknown Object (File)
Jul 3 2026, 2:34 PM
Unknown Object (File)
Jul 3 2026, 2:33 PM
Unknown Object (File)
Jul 3 2026, 5:50 AM
Unknown Object (File)
Jun 20 2026, 7:16 PM
Unknown Object (File)
Jun 20 2026, 7:15 PM
Unknown Object (File)
Jun 20 2026, 5:46 PM
View All Files
Subscribers
Restricted Owners Package

Details

Reviewers
amckinley
Maniphest Tasks
T13325: Various internal APIs calls use the made up word "topographical" when they mean "topological"
Commits
rPc0dc411d2319: Update "phabricator/" for "topological" API changes
Summary

Ref T13325.

Test Plan
  • Grepped for topograph.
  • Viewed a task graph since that's easy, looked fine.

Diff Detail

Repository
rP Phabricator
Branch
topo3
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 23004
Build 31577: Run Core Tests
Build 31576: arc lint + arc unit

Event Timeline

epriestley created this revision.Jun 20 2019, 7:15 PM
Owners added a subscriber: Restricted Owners Package.Jun 20 2019, 7:15 PM
Harbormaster returned this revision to the author for changes because remote builds failed.Jun 20 2019, 7:16 PM
Harbormaster failed remote builds in B23004: Diff 49132!
epriestley requested review of this revision.Jun 20 2019, 7:19 PM

Builds have a hard dependency on D20597.

amckinley accepted this revision.Jun 20 2019, 7:51 PM
This revision is now accepted and ready to land.Jun 20 2019, 7:51 PM
epriestley mentioned this in rP53f8ad14fa92: Fix an issue in Owners where a transaction change could show too many effects.Jun 20 2019, 11:10 PM
This revision was landed with ongoing or failed builds.Jun 20 2019, 11:12 PM
Closed by commit rPc0dc411d2319: Update "phabricator/" for "topological" API changes (authored by epriestley). · Explain Why
This revision was automatically updated to reflect the committed changes.
epriestley added a commit: rPc0dc411d2319: Update "phabricator/" for "topological" API changes.

Revision Contents
Changeset List

PathSize
src/
applications/
harbormaster/
engine/
3 lines
repository/
engine/
4 lines
infrastructure/
graph/
2 lines

Diff 49132

View Options

src/applications/harbormaster/engine/HarbormasterBuildGraph.php

Loading...
View Options

src/applications/repository/engine/PhabricatorRepositoryDiscoveryEngine.php

Loading...
View Options

src/infrastructure/graph/PhabricatorObjectGraph.php

Loading...
Phabricator · Built by Phacility