Page MenuHomePhabricator

Use "link.getAttribute('href')", not "link.href", to bypass dark browser magic
ClosedPublic

Authored by epriestley on Jun 19 2019, 5:24 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Dec 19, 12:53 AM
Unknown Object (File)
Mon, Dec 16, 7:13 PM
Unknown Object (File)
Fri, Dec 13, 4:56 AM
Unknown Object (File)
Fri, Dec 13, 4:56 AM
Unknown Object (File)
Fri, Dec 13, 4:56 AM
Unknown Object (File)
Wed, Dec 11, 3:57 AM
Unknown Object (File)
Nov 22 2024, 5:26 PM
Unknown Object (File)
Nov 20 2024, 11:34 PM
Subscribers
None

Details

Summary

Ref T13302. In at least some browsers (including Safari and Chrome), when you write this:

<a href="#">...</a>

...and then access <that node>.href, you get http://local-domain-whatever.com/path/to/current/page# back.

This is wonderful, but not what we want. Access the raw attribute value instead, which is # in all browsers.

Test Plan
  • In Safari, Chrome, and Firefox:
  • Clicked "Edit Subtasks" from a task.
  • Clicked "Select" buttons to select several tasks.
  • Before: Clicking these button incorrectly closed the dialog (because of D20573).
  • After: Clicking these buttons now selects tasks without closing the dialog.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable