Page MenuHomePhabricator

Use "link.getAttribute('href')", not "link.href", to bypass dark browser magic
ClosedPublic

Authored by epriestley on Jun 19 2019, 5:24 PM.
Tags
None
Referenced Files
F16514160: D20590.id49120.diff
Mon, Jun 16, 8:59 PM
F16393362: D20590.diff
Mon, Jun 16, 1:08 AM
Unknown Object (File)
Fri, May 30, 1:27 AM
Unknown Object (File)
Sun, May 25, 3:09 PM
Unknown Object (File)
Tue, May 20, 9:55 AM
Unknown Object (File)
Apr 26 2025, 6:02 PM
Unknown Object (File)
Apr 24 2025, 11:39 AM
Unknown Object (File)
Apr 22 2025, 3:22 AM
Subscribers
None

Details

Summary

Ref T13302. In at least some browsers (including Safari and Chrome), when you write this:

<a href="#">...</a>

...and then access <that node>.href, you get http://local-domain-whatever.com/path/to/current/page# back.

This is wonderful, but not what we want. Access the raw attribute value instead, which is # in all browsers.

Test Plan
  • In Safari, Chrome, and Firefox:
  • Clicked "Edit Subtasks" from a task.
  • Clicked "Select" buttons to select several tasks.
  • Before: Clicking these button incorrectly closed the dialog (because of D20573).
  • After: Clicking these buttons now selects tasks without closing the dialog.

Diff Detail

Repository
rP Phabricator
Branch
close1
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 22992
Build 31556: Run Core Tests
Build 31555: arc lint + arc unit