Paths

Table of Contentst

Differential D20577

Parse "shallow" frames in the Git "upload-pack" wire protocol parser
ClosedPublic
Actions

Authored by epriestley on Jun 13 2019, 11:31 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Thu, Dec 19, 10:10 PM

	Unknown Object (File)
	Mon, Dec 16, 10:02 AM

	Unknown Object (File)
	Fri, Dec 13, 6:13 PM

	Unknown Object (File)
	Fri, Dec 13, 5:28 PM

	Unknown Object (File)
	Fri, Dec 13, 4:54 AM

	Unknown Object (File)
	Wed, Dec 11, 6:59 AM

	Unknown Object (File)
	Wed, Dec 11, 6:59 AM

	Unknown Object (File)
	Wed, Dec 11, 6:59 AM

Subscribers

None

Details

Reviewers

Maniphest Tasks

T13309: Git protocol proxy can not parse protocol frames if repository on disk is a shallow clone

Commits

rPdda5c13ef549: Parse "shallow" frames in the Git "upload-pack" wire protocol parser

Summary

Fixes T13309. If you void the warranty on a repository on disk and turn it into a shallow clone, Phabricator currently can't serve it.

We don't support hosting shallow working copies, but we should still parse and proxy the protocol rather than breaking in a mysterious way.

Test Plan

Created a shallow working copy with mv X X.full; git clone --depth Y file://.../X.full X in the storage directory on disk.
Cloned it with git clone <uri>.
Deleted all the refs inside it so the wire only has "shallow" frames; cloned it.

Diff Detail

Repository

Branch

shallow1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 22977
Build 31535: Run Core Tests
Build 31534: arc lint + arc unit

Unit TestsFailed
View All

	Time	Test
	1 ms	MetaMTAEmailTransactionCommandTestCase::testGetAllTypes EXCEPTION (Exception): msort() was passed a method ("getRevisionActionOrderVector") which returns "PhutilSortVector" objects. Use "msortv()", not "msort()", to sort a list which produces vectors. #0 /core/data/drydock/workingcopy-82/repo/phabricator/src/applications/differential/command/DifferentialActionEmailCommand.php(59): msort(Array, 'getRevisionActi...') #1 [internal function]: DifferentialActionEmailCommand->getCommandObjects()
	1 ms	AlmanacNamesTestCase::testServiceOrDeviceNames 30 assertions passed.
	0 ms	AlmanacServiceTypeTestCase::testGetAllServiceTypes 1 assertion passed.
	0 ms	AphrontHTTPSinkTestCase::testHTTPHeaderNames 2 assertions passed.
	0 ms	AphrontHTTPSinkTestCase::testHTTPSinkBasics 3 assertions passed.
		View Full Test Results (1 Failed · 368 Passed)

Event Timeline

epriestley created this revision.Jun 13 2019, 11:31 PM

Harbormaster completed remote builds in B22955: Diff 49080.Jun 13 2019, 11:33 PM

epriestley requested review of this revision.Jun 13 2019, 11:33 PM

Minor wordsmithing.

In the Discourse thread (https://discourse.phabricator-community.org/t/how-to-have-a-shallow-git-mirror/2805/) the reporting user also reported that this patch worked in their (illegal, forbidden) use case.

Is it expected that B22956 never completed?

Oh, not sure what happened there -- that's the local result, so maybe I ^C'd too fast. Let me just kick it...

🥾

Harbormaster failed remote builds in B22977: Diff 49102!Jun 18 2019, 1:20 AM

Plus a rebase for the msortv() change.

Harbormaster completed remote builds in B22978: Diff 49103.Jun 18 2019, 1:22 AM

amckinley accepted this revision.Jun 18 2019, 9:08 PM

This revision is now accepted and ready to land.Jun 18 2019, 9:08 PM

Closed by commit rPdda5c13ef549: Parse "shallow" frames in the Git "upload-pack" wire protocol parser (authored by epriestley). · Explain WhyJun 18 2019, 10:15 PM

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rPdda5c13ef549: Parse "shallow" frames in the Git "upload-pack" wire protocol parser.

Revision Contents
Changeset List

Path

Size

src/

applications/

diffusion/

protocol/

DiffusionGitUploadPackWireProtocol.php

106 lines

DiffusionGitWireProtocolRef.php

13 lines

Diff 49102

src/applications/diffusion/protocol/DiffusionGitUploadPackWireProtocol.php

Loading...

src/applications/diffusion/protocol/DiffusionGitWireProtocolRef.php

Loading...