Page MenuHomePhabricator
Differential D20577

Parse "shallow" frames in the Git "upload-pack" wire protocol parser
ClosedPublic
Actions

Authored by epriestley on Jun 13 2019, 11:31 PM.
Tags
None
Referenced Files
F18338121: D20577.id.diff
Mon, Aug 25, 7:41 PM
F18087471: D20577.id49103.diff
Wed, Aug 6, 4:08 AM
F18072410: D20577.id49102.diff
Mon, Aug 4, 4:54 PM
F18049033: D20577.id49080.diff
Sun, Aug 3, 3:08 PM
F18043329: D20577.id49081.diff
Aug 3 2025, 5:46 AM
F17938875: D20577.diff
Jul 31 2025, 2:39 AM
F17928311: D20577.id.diff
Jul 30 2025, 4:01 PM
F17884922: D20577.id49081.diff
Jul 29 2025, 12:10 AM
View All Files
Subscribers
None

Details

Reviewers
amckinley
Maniphest Tasks
T13309: Git protocol proxy can not parse protocol frames if repository on disk is a shallow clone
Commits
rPdda5c13ef549: Parse "shallow" frames in the Git "upload-pack" wire protocol parser
Summary

Fixes T13309. If you void the warranty on a repository on disk and turn it into a shallow clone, Phabricator currently can't serve it.

We don't support hosting shallow working copies, but we should still parse and proxy the protocol rather than breaking in a mysterious way.

Test Plan
  • Created a shallow working copy with mv X X.full; git clone --depth Y file://.../X.full X in the storage directory on disk.
  • Cloned it with git clone <uri>.
  • Deleted all the refs inside it so the wire only has "shallow" frames; cloned it.

Diff Detail

Repository
rP Phabricator
Branch
shallow1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 22955
Build 31501: Run Core Tests
Build 31500: arc lint + arc unit

Event Timeline

epriestley created this revision.Jun 13 2019, 11:31 PM
Harbormaster completed remote builds in B22955: Diff 49080.Jun 13 2019, 11:33 PM
epriestley requested review of this revision.Jun 13 2019, 11:33 PM
epriestley updated this revision to Diff 49081.Jun 13 2019, 11:35 PM
  • Minor wordsmithing.
epriestley added a comment.Jun 17 2019, 5:20 PM

In the Discourse thread (https://discourse.phabricator-community.org/t/how-to-have-a-shallow-git-mirror/2805/) the reporting user also reported that this patch worked in their (illegal, forbidden) use case.

amckinley added a comment.Jun 18 2019, 12:22 AM

Is it expected that B22956 never completed?

epriestley added a comment.Jun 18 2019, 1:17 AM

Oh, not sure what happened there -- that's the local result, so maybe I ^C'd too fast. Let me just kick it...

epriestley updated this revision to Diff 49102.Jun 18 2019, 1:18 AM

🥾

Harbormaster failed remote builds in B22977: Diff 49102!Jun 18 2019, 1:20 AM
epriestley updated this revision to Diff 49103.Jun 18 2019, 1:20 AM
  • Plus a rebase for the msortv() change.
Harbormaster completed remote builds in B22978: Diff 49103.Jun 18 2019, 1:22 AM
amckinley accepted this revision.Jun 18 2019, 9:08 PM
This revision is now accepted and ready to land.Jun 18 2019, 9:08 PM
Closed by commit rPdda5c13ef549: Parse "shallow" frames in the Git "upload-pack" wire protocol parser (authored by epriestley). · Explain WhyJun 18 2019, 10:15 PM
This revision was automatically updated to reflect the committed changes.
epriestley added a commit: rPdda5c13ef549: Parse "shallow" frames in the Git "upload-pack" wire protocol parser.

Revision Contents
Changeset List

PathSize
src/
applications/
diffusion/
protocol/
108 lines
13 lines

Diff 49080

View Options

src/applications/diffusion/protocol/DiffusionGitUploadPackWireProtocol.php

Loading...
View Options

src/applications/diffusion/protocol/DiffusionGitWireProtocolRef.php

Loading...
Phabricator · Built by Phacility