Page MenuHomePhabricator

When a revision is closed, always promote it out of draft
ClosedPublic

Authored by epriestley on May 31 2019, 1:18 PM.
Tags
None
Referenced Files
F14124223: D20565.diff
Sat, Nov 30, 2:05 AM
Unknown Object (File)
Sat, Nov 23, 9:24 AM
Unknown Object (File)
Oct 24 2024, 3:24 AM
Unknown Object (File)
Oct 23 2024, 10:29 AM
Unknown Object (File)
Oct 19 2024, 5:03 AM
Unknown Object (File)
Oct 17 2024, 7:06 AM
Unknown Object (File)
Sep 2 2024, 7:43 PM
Unknown Object (File)
Aug 14 2024, 5:38 AM
Subscribers
None

Details

Summary

Fixes T13300. Currently, if you create a revision and then immediately land it (either using --draft or just beating Harbormaster to the punch) it can be stuck in "Draft" forever.

Instead, count landing changes like this as a publishing action.

Test Plan
  • Used arc diff --hold to create a revision, then pushed the commit immediately.
  • Before change: revision closed, but was stuck in draft.
  • After change: revision closed and was promoted out of draft.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable