Page MenuHomePhabricator

When a revision is closed, always promote it out of draft
ClosedPublic

Authored by epriestley on May 31 2019, 1:18 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Mar 3, 11:46 PM
Unknown Object (File)
Fri, Feb 28, 1:04 AM
Unknown Object (File)
Feb 9 2025, 7:50 AM
Unknown Object (File)
Feb 9 2025, 7:50 AM
Unknown Object (File)
Feb 9 2025, 7:50 AM
Unknown Object (File)
Feb 9 2025, 7:50 AM
Unknown Object (File)
Jan 31 2025, 1:52 AM
Unknown Object (File)
Jan 27 2025, 5:18 AM
Subscribers
None

Details

Summary

Fixes T13300. Currently, if you create a revision and then immediately land it (either using --draft or just beating Harbormaster to the punch) it can be stuck in "Draft" forever.

Instead, count landing changes like this as a publishing action.

Test Plan
  • Used arc diff --hold to create a revision, then pushed the commit immediately.
  • Before change: revision closed, but was stuck in draft.
  • After change: revision closed and was promoted out of draft.

Diff Detail

Repository
rP Phabricator
Branch
publish1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 22933
Build 31464: Run Core Tests
Build 31463: arc lint + arc unit