Page MenuHomePhabricator

When a revision is closed, always promote it out of draft
ClosedPublic

Authored by epriestley on May 31 2019, 1:18 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Aug 13, 1:35 AM
Unknown Object (File)
Jul 1 2026, 7:26 PM
Unknown Object (File)
Apr 10 2026, 3:29 AM
Unknown Object (File)
Mar 8 2026, 2:43 PM
Unknown Object (File)
Mar 7 2026, 12:27 AM
Unknown Object (File)
Jan 19 2026, 9:45 PM
Unknown Object (File)
Jan 11 2026, 12:50 AM
Unknown Object (File)
Nov 27 2025, 7:04 AM
Subscribers
None

Details

Summary

Fixes T13300. Currently, if you create a revision and then immediately land it (either using --draft or just beating Harbormaster to the punch) it can be stuck in "Draft" forever.

Instead, count landing changes like this as a publishing action.

Test Plan
  • Used arc diff --hold to create a revision, then pushed the commit immediately.
  • Before change: revision closed, but was stuck in draft.
  • After change: revision closed and was promoted out of draft.

Diff Detail

Repository
rP Phabricator
Branch
publish1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 22933
Build 31464: Run Core Tests
Build 31463: arc lint + arc unit