Paths

Table of Contentst

Differential D20527

When an object is referenced by URI, treat it like a mention
ClosedPublic
Actions

Authored by epriestley on May 20 2019, 4:59 PM.

Tags

None

Referenced Files

	F15389060: D20527.id.diff
	Sat, Mar 15, 4:51 AM

	F15389048: D20527.diff
	Sat, Mar 15, 4:50 AM

	Unknown Object (File)
	Mon, Feb 24, 2:37 AM

	Unknown Object (File)
	Feb 16 2025, 6:35 PM

	Unknown Object (File)
	Feb 16 2025, 2:39 PM

	Unknown Object (File)
	Feb 9 2025, 5:10 PM

	Unknown Object (File)
	Feb 9 2025, 7:47 AM

	Unknown Object (File)
	Feb 9 2025, 7:47 AM

Subscribers

None

Details

Reviewers

Maniphest Tasks

T13291: Implement a "{src ...}" rule in Remarkup for referencing source files in Diffusion

Commits

rP33688c8a41eb: When an object is referenced by URI, treat it like a mention

Summary

Ref T13291. Currently, T123 is a mention and adds an "alice mentioned this on Txxx." to T123, but https://install.com/T123 is not a mention.

Make the full URI a mention.

Test Plan

Commented a full URI, saw the target object get a mention story in its timeline.

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.May 20 2019, 4:59 PM

Harbormaster completed remote builds in B22830: Diff 48954.May 20 2019, 5:01 PM

epriestley requested review of this revision.May 20 2019, 5:01 PM

epriestley added a child revision: D20528: Implement Asana and JIRA external links via HyperlinkEngineExtension, not separate Remarkup rules.May 20 2019, 6:23 PM

amckinley accepted this revision.May 21 2019, 5:30 PM

This revision is now accepted and ready to land.May 21 2019, 5:30 PM

Closed by commit rP33688c8a41eb: When an object is referenced by URI, treat it like a mention (authored by epriestley). · Explain WhyMay 21 2019, 7:13 PM

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rP33688c8a41eb: When an object is referenced by URI, treat it like a mention.

epriestley mentioned this in T13291: Implement a "{src ...}" rule in Remarkup for referencing source files in Diffusion.May 22 2019, 11:51 AM

Revision Contents
Changeset List

Path

Size

src/

applications/

meta/

engineextension/

PhabricatorSelfHyperlinkEngineExtension.php

13 lines

Diff 48972

src/applications/meta/engineextension/PhabricatorSelfHyperlinkEngineExtension.php

Loading...