Differential D20529

Support timeouts in OAuth1Future
ClosedPublic
Actions

Authored by epriestley on May 20 2019, 6:39 PM.

Details

Reviewers

Maniphest Tasks

T13285: Service failures in JIRA can cascade into service failures in Phabricator
T13291: Implement a "{src ...}" rule in Remarkup for referencing source files in Diffusion

Commits

rPHU07e92da74e9a: Support timeouts in OAuth1Future

Summary

Ref T13291. Ref T13285. Add "setTimeout()" to OAuth1Future to support adding timeouts to Doorkeeper OAuth requests, so we're less likely to cascade into explosive failure if a linked JIRA instance dies.

Test Plan

See next change.

Diff Detail

Repository

rPHU libphutil

Branch

doorkeeper2

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 22834
Build 31323: Run Core Tests
Build 31322: arc lint + arc unit

Event Timeline

epriestley created this revision.May 20 2019, 6:39 PM

Harbormaster completed remote builds in B22832: Diff 48956.May 20 2019, 6:39 PM

epriestley requested review of this revision.May 20 2019, 6:39 PM

Also add support to the "AsanaFuture", which is a separate future.

Harbormaster completed remote builds in B22834: Diff 48958.May 20 2019, 6:46 PM

amckinley accepted this revision.May 21 2019, 5:44 PM

This revision is now accepted and ready to land.May 21 2019, 5:44 PM

Closed by commit rPHU07e92da74e9a: Support timeouts in OAuth1Future (authored by epriestley). · Explain WhyMay 21 2019, 7:13 PM

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rPHU07e92da74e9a: Support timeouts in OAuth1Future.

Revision Contents
Changeset List

Path

Size

src/

future/

asana/

PhutilAsanaFuture.php

15 lines

oauth/

PhutilOAuth1Future.php

15 lines

Diff 48958

View Options

src/future/asana/PhutilAsanaFuture.php