Page MenuHomePhabricator

Support timeouts in OAuth1Future
ClosedPublic

Authored by epriestley on May 20 2019, 6:39 PM.

Details

Summary

Ref T13291. Ref T13285. Add "setTimeout()" to OAuth1Future to support adding timeouts to Doorkeeper OAuth requests, so we're less likely to cascade into explosive failure if a linked JIRA instance dies.

Test Plan

See next change.

Diff Detail

Repository
rPHU libphutil
Branch
doorkeeper2
Lint
Lint OK
Unit
Unit Tests OK
Build Status
Buildable 22832
Build 31319: Run Core Tests
Build 31318: arc lint + arc unit

Event Timeline

epriestley created this revision.May 20 2019, 6:39 PM
epriestley requested review of this revision.May 20 2019, 6:39 PM
epriestley updated this revision to Diff 48958.May 20 2019, 6:45 PM
  • Also add support to the "AsanaFuture", which is a separate future.
amckinley accepted this revision.May 21 2019, 5:44 PM
This revision is now accepted and ready to land.May 21 2019, 5:44 PM
This revision was automatically updated to reflect the committed changes.