Page MenuHomePhabricator
Differential D20529

Support timeouts in OAuth1Future
ClosedPublic
Actions

Authored by epriestley on May 20 2019, 6:39 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Apr 23, 10:35 AM
Unknown Object (File)
Mon, Apr 22, 7:53 AM
Unknown Object (File)
Sat, Apr 20, 4:49 PM
Unknown Object (File)
Sat, Apr 20, 2:15 AM
Unknown Object (File)
Fri, Apr 19, 8:36 PM
Unknown Object (File)
Fri, Apr 12, 1:35 PM
Unknown Object (File)
Fri, Mar 29, 1:30 PM
Unknown Object (File)
Thu, Mar 28, 9:08 PM
View All Files
Subscribers
None

Details

Reviewers
amckinley
Maniphest Tasks
T13285: Service failures in JIRA can cascade into service failures in Phabricator
T13291: Implement a "{src ...}" rule in Remarkup for referencing source files in Diffusion
Commits
rPHU07e92da74e9a: Support timeouts in OAuth1Future
Summary

Ref T13291. Ref T13285. Add "setTimeout()" to OAuth1Future to support adding timeouts to Doorkeeper OAuth requests, so we're less likely to cascade into explosive failure if a linked JIRA instance dies.

Test Plan

See next change.

Diff Detail

Repository
rPHU libphutil
Branch
doorkeeper2
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 22832
Build 31319: Run Core Tests
Build 31318: arc lint + arc unit

Event Timeline

epriestley created this revision.May 20 2019, 6:39 PM
Harbormaster completed remote builds in B22832: Diff 48956.May 20 2019, 6:39 PM
epriestley requested review of this revision.May 20 2019, 6:39 PM
epriestley updated this revision to Diff 48958.May 20 2019, 6:45 PM
  • Also add support to the "AsanaFuture", which is a separate future.
Harbormaster completed remote builds in B22834: Diff 48958.May 20 2019, 6:46 PM
amckinley accepted this revision.May 21 2019, 5:44 PM
This revision is now accepted and ready to land.May 21 2019, 5:44 PM
Closed by commit rPHU07e92da74e9a: Support timeouts in OAuth1Future (authored by epriestley). · Explain WhyMay 21 2019, 7:13 PM
This revision was automatically updated to reflect the committed changes.
epriestley added a commit: rPHU07e92da74e9a: Support timeouts in OAuth1Future.

Revision Contents
Changeset List

PathSize
src/
future/
oauth/
15 lines

Diff 48956

View Options

src/future/oauth/PhutilOAuth1Future.php

Loading...
Phabricator · Built by Phacility