Page MenuHomePhabricator

Call `$linter->setEngine` in linter tests
ClosedPublic

Authored by joshuaspence on May 13 2019, 4:27 AM.
Tags
None
Referenced Files
F21993777: D20515.id48923.diff
Mon, Aug 17, 5:28 PM
F21992168: D20515.diff
Mon, Aug 17, 4:49 PM
F21967328: D20515.diff
Mon, Aug 17, 12:13 AM
F21967324: D20515.diff
Mon, Aug 17, 12:13 AM
F21967322: D20515.diff
Mon, Aug 17, 12:13 AM
F21967321: D20515.diff
Mon, Aug 17, 12:13 AM
Unknown Object (File)
Jul 8 2026, 6:00 PM
Unknown Object (File)
Jul 7 2026, 7:49 PM
Subscribers

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Summary

We aren't calling $linter->setEngine($engine), even though we do have an $engine. This causes unit tests for any linters which require an engine to fail.

Test Plan

Ran the unit tests for a third-party linter.

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable