Page MenuHomePhabricator

Call `$linter->setEngine` in linter tests
ClosedPublic

Authored by joshuaspence on May 13 2019, 4:27 AM.

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Summary

We aren't calling $linter->setEngine($engine), even though we do have an $engine. This causes unit tests for any linters which require an engine to fail.

Test Plan

Ran the unit tests for a third-party linter.

Diff Detail

Repository
rARC Arcanist
Branch
master
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 22781
Build 31249: Run Core Tests
Build 31248: arc lint + arc unit

Event Timeline

joshuaspence created this revision.May 13 2019, 4:27 AM
joshuaspence requested review of this revision.May 13 2019, 4:28 AM
epriestley accepted this revision.May 14 2019, 2:09 PM
This revision is now accepted and ready to land.May 14 2019, 2:09 PM
This revision was automatically updated to reflect the committed changes.