Page MenuHomePhabricator

Call `$linter->setEngine` in linter tests
ClosedPublic

Authored by joshuaspence on May 13 2019, 4:27 AM.
Tags
None
Referenced Files
F18818457: D20515.diff
Wed, Oct 22, 12:28 AM
F18743768: D20515.id.diff
Fri, Oct 3, 12:49 AM
F18742496: D20515.id.diff
Thu, Oct 2, 7:42 PM
F18737246: D20515.diff
Wed, Oct 1, 9:39 AM
F18721947: D20515.diff
Sep 29 2025, 9:55 PM
F18645810: D20515.diff
Sep 19 2025, 8:32 AM
F18596266: D20515.id48923.diff
Sep 13 2025, 12:12 AM
F18586353: D20515.id.diff
Sep 11 2025, 6:21 PM
Subscribers

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Summary

We aren't calling $linter->setEngine($engine), even though we do have an $engine. This causes unit tests for any linters which require an engine to fail.

Test Plan

Ran the unit tests for a third-party linter.

Diff Detail

Repository
rARC Arcanist
Branch
master
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 22781
Build 31249: Run Core Tests
Build 31248: arc lint + arc unit