Paths

Table of Contentst

Differential D20515

Call `$linter->setEngine` in linter tests
ClosedPublic
Actions

Authored by joshuaspence on May 13 2019, 4:27 AM.

Tags

None

Referenced Files

	F22775361: D20515.diff
	Mon, Oct 5, 11:08 PM

	F22662673: D20515.id48923.diff
	Thu, Oct 1, 10:27 AM

	F22567037: D20515.diff
	Fri, Sep 25, 6:59 PM

	F22506807: D20515.id.diff
	Fri, Sep 18, 9:47 AM

	Unknown Object (File)
	Aug 17 2026, 5:28 PM

	Unknown Object (File)
	Aug 17 2026, 4:49 PM

	Unknown Object (File)
	Aug 17 2026, 12:13 AM

	Unknown Object (File)
	Aug 17 2026, 12:13 AM

View All Files

Subscribers

Korvin

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Summary

We aren't calling $linter->setEngine($engine), even though we do have an $engine. This causes unit tests for any linters which require an engine to fail.

Test Plan

Ran the unit tests for a third-party linter.

Diff Detail

Repository

rARC Arcanist

Branch

master

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 22781
Build 31249: Run Core Tests
Build 31248: arc lint + arc unit

Event Timeline

joshuaspence created this revision.May 13 2019, 4:27 AM

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptMay 13 2019, 4:27 AM

Harbormaster completed remote builds in B22781: Diff 48908.May 13 2019, 4:28 AM

joshuaspence requested review of this revision.May 13 2019, 4:28 AM

Herald added a subscriber: Korvin. · View Herald TranscriptMay 13 2019, 4:28 AM

epriestley accepted this revision.May 14 2019, 2:09 PM

This revision is now accepted and ready to land.May 14 2019, 2:09 PM

Closed by commit rARC4f583dded366: Call `$linter->setEngine` in linter tests (authored by joshuaspence). · Explain WhyMay 14 2019, 11:02 PM

This revision was automatically updated to reflect the committed changes.

joshuaspence added an edge: rARC4f583dded366: Call `$linter->setEngine` in linter tests.

Revision Contents
Changeset List

Path

Size

src/

lint/

linter/

__tests__/

ArcanistLinterTestCase.php

1 line

Diff 48908

View Options

src/lint/linter/tests/ArcanistLinterTestCase.php

Call `$linter->setEngine` in linter testsClosedPublicActions