Page MenuHomePhabricator

Don't mark subscribes/mentions as "Lock Overridden"
ClosedPublic

Authored by epriestley on May 10 2019, 6:48 PM.
Tags
None
Referenced Files
F13247237: D20513.id48920.diff
Thu, May 23, 5:10 PM
F13214766: D20513.diff
Fri, May 17, 12:46 PM
F13211209: D20513.diff
Fri, May 17, 5:34 AM
F13209027: D20513.id48906.diff
Thu, May 16, 9:15 PM
F13195005: D20513.diff
Sun, May 12, 10:03 PM
F13184070: D20513.id.diff
Fri, May 10, 2:53 PM
F13177757: D20513.diff
Wed, May 8, 7:56 PM
Unknown Object (File)
Tue, May 7, 10:47 AM
Subscribers
None

Details

Reviewers
amckinley
Summary

See PHI1209. When a task is in "Hard Lock" mode, it's still possible to apply some changes to it. Notably:

  • You can subscribe/unsubscribe.
  • You can mention it on another object.
  • You can add a relationship from some other object to it (e.g., select it as a "Parent Task" for some other task).

Currently, these types of edits will show a "Lock Overridden" timeline emblem icon. However, they should not: you didn't override a lock to make these changes, they just bypass locks.

For now, special case these cases (self subscribe/unsubscribe + inverse edge edits) so they don't get the little icon, since I think this list is exhaustive today.

Some day we should modularize this, but we'd need code like this anyway (since TYPE_SUBSCRIBE is not modular yet), and this seems unlikely to cause problems even if it's a bit rough.

Test Plan
  • Hard-locked a task.
    • Subscribed/unsubscribed, mentioned, relationship'd it as a non-author. No timeline emblems.
  • Soft-locked a task.
    • Subscribed/unsubscribed, mentioned, relationship'd it, no timeline emblems.
    • Clicked "Edit", answered "yes" to the override prompt, edited it. Got a timeline emblem.
  • Added some comments and stuff to a normal non-locked task, no emblems.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

amckinley added inline comments.
src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php
5218

"test if"

This revision is now accepted and ready to land.May 14 2019, 2:50 PM