Page MenuHomePhabricator

Don't mark subscribes/mentions as "Lock Overridden"
ClosedPublic

Authored by epriestley on May 10 2019, 6:48 PM.
Tags
None
Referenced Files
F18788037: D20513.id48906.diff
Wed, Oct 15, 2:35 AM
F18767614: D20513.id48920.diff
Tue, Oct 7, 11:26 PM
F18667560: D20513.diff
Wed, Sep 24, 11:31 AM
F18644723: D20513.id.diff
Fri, Sep 19, 5:58 AM
F18570156: D20513.id48920.diff
Sep 10 2025, 3:12 AM
F18570149: D20513.id48906.diff
Sep 10 2025, 3:11 AM
F18053278: D20513.id.diff
Aug 4 2025, 4:24 AM
F18048374: D20513.diff
Aug 3 2025, 1:32 PM
Subscribers
None

Details

Reviewers
amckinley
Summary

See PHI1209. When a task is in "Hard Lock" mode, it's still possible to apply some changes to it. Notably:

  • You can subscribe/unsubscribe.
  • You can mention it on another object.
  • You can add a relationship from some other object to it (e.g., select it as a "Parent Task" for some other task).

Currently, these types of edits will show a "Lock Overridden" timeline emblem icon. However, they should not: you didn't override a lock to make these changes, they just bypass locks.

For now, special case these cases (self subscribe/unsubscribe + inverse edge edits) so they don't get the little icon, since I think this list is exhaustive today.

Some day we should modularize this, but we'd need code like this anyway (since TYPE_SUBSCRIBE is not modular yet), and this seems unlikely to cause problems even if it's a bit rough.

Test Plan
  • Hard-locked a task.
    • Subscribed/unsubscribed, mentioned, relationship'd it as a non-author. No timeline emblems.
  • Soft-locked a task.
    • Subscribed/unsubscribed, mentioned, relationship'd it, no timeline emblems.
    • Clicked "Edit", answered "yes" to the override prompt, edited it. Got a timeline emblem.
  • Added some comments and stuff to a normal non-locked task, no emblems.

Diff Detail

Repository
rP Phabricator
Branch
lock1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 22779
Build 31245: Run Core Tests
Build 31244: arc lint + arc unit

Event Timeline

amckinley added inline comments.
src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php
5218

"test if"

This revision is now accepted and ready to land.May 14 2019, 2:50 PM