Page MenuHomePhabricator

When viewing a workboard, only link to parent workboards in crumbs if parents have workboards
ClosedPublic

Authored by epriestley on May 13 2019, 2:22 PM.
Tags
None
Referenced Files
F15406962: D20517.id48910.diff
Tue, Mar 18, 2:59 PM
F15385672: D20517.id48928.diff
Fri, Mar 14, 11:07 PM
F15380619: D20517.diff
Fri, Mar 14, 3:52 AM
Unknown Object (File)
Fri, Feb 28, 11:15 PM
Unknown Object (File)
Sat, Feb 22, 7:39 PM
Unknown Object (File)
Wed, Feb 19, 11:44 AM
Unknown Object (File)
Feb 17 2025, 7:43 PM
Unknown Object (File)
Feb 13 2025, 10:09 PM
Subscribers
None

Details

Reviewers
amckinley
Summary

Depends on D20516. See PHI1247. In D20331, I made the crumbs on workboards point at ancestor workboards.

However, this isn't a great destination if an ancestor doesn't actually have a workboard. In this case, point at the normal profile URI instead.

Test Plan
  • Viewed a milestone workboard with a parent that had no workboard. Saw a profile link instead of a workboard link (new behavior).
  • Viewed a milestone workboard with a parent that also had a workboard. Saw a workboard link (existing old behavior still works).

Diff Detail

Repository
rP Phabricator
Branch
board2
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 22783
Build 31253: Run Core Tests
Build 31252: arc lint + arc unit