Page MenuHomePhabricator

When viewing a workboard, only link to parent workboards in crumbs if parents have workboards
ClosedPublic

Authored by epriestley on May 13 2019, 2:22 PM.
Tags
None
Referenced Files
F15465765: D20517.id48928.diff
Wed, Apr 2, 10:59 PM
F15462664: D20517.id.diff
Tue, Apr 1, 4:34 PM
F15460981: D20517.id48910.diff
Tue, Apr 1, 4:02 AM
F15448984: D20517.diff
Fri, Mar 28, 8:03 AM
F15427368: D20517.diff
Sun, Mar 23, 2:02 PM
F15423937: D20517.diff
Sat, Mar 22, 7:33 PM
F15406962: D20517.id48910.diff
Tue, Mar 18, 2:59 PM
F15385672: D20517.id48928.diff
Fri, Mar 14, 11:07 PM
Subscribers
None

Details

Reviewers
amckinley
Summary

Depends on D20516. See PHI1247. In D20331, I made the crumbs on workboards point at ancestor workboards.

However, this isn't a great destination if an ancestor doesn't actually have a workboard. In this case, point at the normal profile URI instead.

Test Plan
  • Viewed a milestone workboard with a parent that had no workboard. Saw a profile link instead of a workboard link (new behavior).
  • Viewed a milestone workboard with a parent that also had a workboard. Saw a workboard link (existing old behavior still works).

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable