Page MenuHomePhabricator

Remove unnecessary "," from Pylint version regex
ClosedPublic

Authored by epriestley on May 8 2019, 5:21 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Jan 23, 4:16 AM
Unknown Object (File)
Wed, Jan 15, 7:02 PM
Unknown Object (File)
Sat, Jan 11, 1:18 AM
Unknown Object (File)
Dec 23 2024, 10:46 AM
Unknown Object (File)
Dec 23 2024, 6:15 AM
Unknown Object (File)
Dec 22 2024, 8:18 PM
Unknown Object (File)
Dec 14 2024, 7:44 AM
Unknown Object (File)
Dec 13 2024, 4:52 AM
Subscribers
None

Details

Summary

See PHI1238. This "," in the regex can only make the lint binding fail if there is no "," in the version output string. In modern versions of Pylint, there is (apparently) no comma in the version string. Remove it.

See also https://discourse.phabricator-community.org/t/arcanistpylintlinter-version-regex-issue/2688

Test Plan
$ pip install pylint
Traceback (most recent call last):
  File "/Users/epriestley/Library/Python/2.7/bin/pip", line 6, in <module>
    from pip._internal import main
ImportError: No module named pip._internal

¯\_(ツ)_/¯

Diff Detail

Repository
rARC Arcanist
Branch
pylint1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 22771
Build 31229: Run Core Tests
Build 31228: arc lint + arc unit