Page MenuHomePhabricator

Provide chart function labels over the wire instead of making them up
ClosedPublic

Authored by epriestley on May 8 2019, 2:22 PM.
Tags
None
Referenced Files
F15407260: D20501.id.diff
Tue, Mar 18, 4:33 PM
F15406660: D20501.id49001.diff
Tue, Mar 18, 1:10 PM
F15401789: D20501.diff
Mon, Mar 17, 7:16 PM
Unknown Object (File)
Mon, Mar 3, 11:43 PM
Unknown Object (File)
Mon, Mar 3, 11:42 PM
Unknown Object (File)
Mon, Mar 3, 11:42 PM
Unknown Object (File)
Mon, Mar 3, 11:42 PM
Unknown Object (File)
Feb 15 2025, 5:28 AM
Subscribers

Details

Summary

Ref T13279. Makes charts incrementally more useful by allowing the server to provide labels and colors for functions.

Test Plan

Screen Shot 2019-05-08 at 7.16.14 AM.png (1×1 px, 193 KB)

Diff Detail

Repository
rP Phabricator
Branch
chart24
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 22767
Build 31221: Run Core Tests
Build 31220: arc lint + arc unit

Event Timeline

amckinley added inline comments.
src/applications/fact/chart/PhabricatorChartStackedAreaDataset.php
138

Intended placeholder?

This revision is now accepted and ready to land.May 21 2019, 9:38 PM
src/applications/fact/chart/PhabricatorChartStackedAreaDataset.php
138

Yeah, I think this gets a real name in a followup.