Page MenuHomePhabricator
Differential D20501

Provide chart function labels over the wire instead of making them up
ClosedPublic
Actions

Authored by epriestley on May 8 2019, 2:22 PM.
Tags
None
Referenced Files
F13050802: D20501.id49001.diff
Fri, Apr 19, 3:12 AM
F13050801: D20501.id48894.diff
Fri, Apr 19, 3:12 AM
F13050800: D20501.id.diff
Fri, Apr 19, 3:12 AM
Unknown Object (File)
Thu, Apr 11, 4:19 AM
Unknown Object (File)
Sun, Apr 7, 8:07 AM
Unknown Object (File)
Mon, Apr 1, 2:03 PM
Unknown Object (File)
Tue, Mar 26, 7:14 PM
Unknown Object (File)
Tue, Mar 26, 7:14 PM
View All Files
Subscribers
yelirekim

Details

Reviewers
amckinley
Maniphest Tasks
T13279: Build Charting for Facts
Commits
rPa80426b339c4: Provide chart function labels over the wire instead of making them up
Summary

Ref T13279. Makes charts incrementally more useful by allowing the server to provide labels and colors for functions.

Test Plan

Screen Shot 2019-05-08 at 7.16.14 AM.png (1×1 px, 193 KB)

Diff Detail

Repository
rP Phabricator
Branch
chart24
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 22767
Build 31221: Run Core Tests
Build 31220: arc lint + arc unit

Event Timeline

epriestley created this revision.May 8 2019, 2:22 PM
Herald added a subscriber: yelirekim. · View Herald TranscriptMay 8 2019, 2:22 PM
Harbormaster completed remote builds in B22767: Diff 48894.May 8 2019, 2:24 PM
epriestley requested review of this revision.May 8 2019, 2:24 PM
amckinley accepted this revision.May 21 2019, 9:38 PM
amckinley added inline comments.
src/applications/fact/chart/PhabricatorChartStackedAreaDataset.php
138

Intended placeholder?

This revision is now accepted and ready to land.May 21 2019, 9:38 PM
epriestley added inline comments.May 22 2019, 12:22 PM
src/applications/fact/chart/PhabricatorChartStackedAreaDataset.php
138

Yeah, I think this gets a real name in a followup.

Closed by commit rPa80426b339c4: Provide chart function labels over the wire instead of making them up (authored by epriestley). · Explain WhyMay 22 2019, 12:23 PM
This revision was automatically updated to reflect the committed changes.
epriestley added a commit: rPa80426b339c4: Provide chart function labels over the wire instead of making them up.
epriestley mentioned this in rPa80426b339c4: Provide chart function labels over the wire instead of making them up.

Revision Contents
Changeset List

PathSize
resources/
celerity/
src/
applications/
fact/
chart/
17 lines
56 lines
15 lines
webroot/
rsrc/
js/
application/
fact/
13 lines
10 lines
35 lines

Diff 48894

View Options

resources/celerity/map.php

Loading...
View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/fact/chart/PhabricatorChartFunction.php

Loading...
View Options

src/applications/fact/chart/PhabricatorChartFunctionLabel.php

Loading...
View Options

src/applications/fact/chart/PhabricatorChartStackedAreaDataset.php

Loading...
View Options

webroot/rsrc/js/application/fact/Chart.js

Loading...
View Options

webroot/rsrc/js/application/fact/ChartCurtainView.js

Loading...
View Options

webroot/rsrc/js/application/fact/ChartFunctionLabel.js

Loading...
Phabricator · Built by Phacility