Page MenuHomePhabricator

Fix a potential double-prompt in "arc land" when landing with ongoing builds
ClosedPublic

Authored by epriestley on May 3 2019, 5:16 PM.
Tags
None
Referenced Files
F13144957: D20494.diff
Fri, May 3, 8:39 AM
Unknown Object (File)
Fri, Apr 26, 1:25 AM
Unknown Object (File)
Thu, Apr 25, 2:29 AM
Unknown Object (File)
Fri, Apr 19, 8:29 PM
Unknown Object (File)
Apr 2 2024, 3:13 PM
Unknown Object (File)
Mar 28 2024, 6:59 PM
Unknown Object (File)
Mar 28 2024, 5:13 PM
Unknown Object (File)
Mar 12 2024, 9:16 PM
Subscribers
None

Details

Reviewers
amckinley
Summary

The recently-added, build-plan-behavior-aware check here does all of its own prompting, so we should skip the other prompting if it doesn't throw.

Test Plan

Will arc land something sketchy sooner or later.

Diff Detail

Repository
rARC Arcanist
Branch
land1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 22759
Build 31206: Run Core Tests
Build 31205: arc lint + arc unit