Page MenuHomePhabricator

Fix a potential double-prompt in "arc land" when landing with ongoing builds
ClosedPublic

Authored by epriestley on May 3 2019, 5:16 PM.
Tags
None
Referenced Files
F12839013: D20494.diff
Thu, Mar 28, 6:59 PM
F12837601: D20494.diff
Thu, Mar 28, 5:13 PM
Unknown Object (File)
Tue, Mar 12, 9:16 PM
Unknown Object (File)
Jan 27 2024, 4:50 AM
Unknown Object (File)
Dec 20 2023, 4:44 AM
Unknown Object (File)
Nov 30 2023, 5:28 AM
Unknown Object (File)
Nov 18 2023, 3:59 PM
Unknown Object (File)
Oct 30 2023, 11:21 AM
Subscribers
None

Details

Reviewers
amckinley
Summary

The recently-added, build-plan-behavior-aware check here does all of its own prompting, so we should skip the other prompting if it doesn't throw.

Test Plan

Will arc land something sketchy sooner or later.

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable