Page MenuHomePhabricator

Fix a potential double-prompt in "arc land" when landing with ongoing builds
ClosedPublic

Authored by epriestley on May 3 2019, 5:16 PM.
Tags
None
Referenced Files
F13299988: D20494.diff
Fri, Jun 7, 8:40 AM
F13261522: D20494.diff
Mon, May 27, 1:08 AM
F13258392: D20494.id48921.diff
Sun, May 26, 8:59 AM
F13244118: D20494.diff
Thu, May 23, 4:32 AM
F13241041: D20494.id48886.diff
Wed, May 22, 6:46 PM
F13222552: D20494.diff
Sun, May 19, 3:45 AM
F13205227: D20494.diff
May 15 2024, 1:36 AM
F13192919: D20494.id48886.diff
May 12 2024, 10:40 AM
Subscribers
None

Details

Reviewers
amckinley
Summary

The recently-added, build-plan-behavior-aware check here does all of its own prompting, so we should skip the other prompting if it doesn't throw.

Test Plan

Will arc land something sketchy sooner or later.

Diff Detail

Repository
rARC Arcanist
Branch
land1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 22759
Build 31206: Run Core Tests
Build 31205: arc lint + arc unit