Remove the legacy chart behavior from Maniphest
ClosedPublic
Actions

Authored by epriestley on Apr 30 2019, 3:56 PM.

Details

Reviewers

amckinley

Maniphest Tasks

T13279: Build Charting for Facts

Commits

rP146317f2c447: Remove the legacy chart behavior from Maniphest

Summary

Depends on D20486. Ref T13279. Now that the "Reports" UI uses a panel to draw a real chart from Facts, throw away the copy of the old code.

Test Plan

grep

Diff Detail

Repository

rP Phabricator

Branch

chart16

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 22742
Build 31180: Run Core Tests
Build 31179: arc lint + arc unit

Event Timeline

epriestley created this revision.Apr 30 2019, 3:56 PM

Harbormaster completed remote builds in B22742: Diff 48869.Apr 30 2019, 3:58 PM

epriestley requested review of this revision.Apr 30 2019, 3:58 PM

epriestley added a child revision: D20488: Fix handling of "null" domain values in Charts.Apr 30 2019, 4:43 PM

amckinley accepted this revision.May 1 2019, 2:01 PM

This revision is now accepted and ready to land.May 1 2019, 2:01 PM

Closed by commit rP146317f2c447: Remove the legacy chart behavior from Maniphest (authored by epriestley). · Explain WhyMay 22 2019, 11:48 AM

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rP146317f2c447: Remove the legacy chart behavior from Maniphest.

epriestley mentioned this in rP146317f2c447: Remove the legacy chart behavior from Maniphest.

Revision Contents
Changeset List

Path

Size

resources/

celerity/

map.php

webroot/

rsrc/

js/

application/

maniphest/

behavior-line-chart-legacy.js

Diff 48869

View Options

resources/celerity/map.php