Ref T13279. This changes the chart controller:
- if we have no arguments, build a demo chart and redirect to it;
- otherwise, load the specified chart from storage and render it.
This mostly prepares for "Chart" panels on dashboards.
Details
Details
- Reviewers
amckinley - Maniphest Tasks
- T13279: Build Charting for Facts
- Commits
- rPc458b50b8569: Render charts from storage instead of just one ad-hoc hard-coded chart
Visited /fact/chart/, got redirected to a chart from storage.
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Branch
- chart12
- Lint
Lint Passed Severity Location Code Message Advice src/applications/fact/controller/PhabricatorFactChartController.php:30 XHP16 TODO Comment - Unit
Tests Passed - Build Status
Buildable 22738 Build 31172: Run Core Tests Build 31171: arc lint + arc unit