Page MenuHomePhabricator

Render charts from storage instead of just one ad-hoc hard-coded chart
ClosedPublic

Authored by epriestley on Apr 30 2019, 3:31 PM.

Details

Summary

Ref T13279. This changes the chart controller:

  • if we have no arguments, build a demo chart and redirect to it;
  • otherwise, load the specified chart from storage and render it.

This mostly prepares for "Chart" panels on dashboards.

Test Plan

Visited /fact/chart/, got redirected to a chart from storage.

Diff Detail

Repository
rP Phabricator
Branch
chart12
Lint
Lint OK
SeverityLocationCodeMessage
Advicesrc/applications/fact/controller/PhabricatorFactChartController.php:30XHP16TODO Comment
Unit
Unit Tests OK
Build Status
Buildable 22738
Build 31172: Run Core Tests
Build 31171: arc lint + arc unit