Differential D20478

When building a synthetic diff in Differential, adjust diff properties correctly
ClosedPublic
Actions

Authored by epriestley on Apr 25 2019, 10:09 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Fri, Feb 14, 10:53 PM

	Unknown Object (File)
	Fri, Feb 14, 10:53 PM

	Unknown Object (File)
	Fri, Feb 14, 10:53 PM

	Unknown Object (File)
	Fri, Feb 14, 10:53 PM

	Unknown Object (File)
	Mon, Feb 10, 8:02 PM

	Unknown Object (File)
	Sun, Feb 9, 7:43 AM

	Unknown Object (File)
	Sun, Feb 9, 7:43 AM

	Unknown Object (File)
	Sun, Feb 9, 7:43 AM

Subscribers

None

Details

Reviewers

Summary

See PHI1218. When rendering "A vs B", we currently show the properties of diff A without modification.

Instead, take properties from the same place we're taking change details.

See T12664 for a followup.

Test Plan

In diff A, removed "+x" from a file.
In diff B, changed the file but did not remove "+x" from it.
Diffed B vs A.
- Before change: UI incorrectly shows "+x" removed (both sides incorrect, just showing the change from diff A).
- After change: UI shows 100644 -> null, which is half right.

Diff Detail

Repository

Branch

flag1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 22725
Build 31152: Run Core Tests
Build 31151: arc lint + arc unit

Event Timeline

epriestley created this revision.Apr 25 2019, 10:09 PM

epriestley mentioned this in T12664: Update diff/patch parsing to extract more metadata and parse a wider range of formats.Apr 25 2019, 10:11 PM

Harbormaster completed remote builds in B22725: Diff 48850.Apr 25 2019, 10:11 PM

epriestley requested review of this revision.Apr 25 2019, 10:11 PM

amckinley accepted this revision.Apr 29 2019, 7:52 PM

amckinley edited the summary of this revision. (Show Details)

This revision is now accepted and ready to land.Apr 29 2019, 7:53 PM

Closed by commit rP6eae75d8f2ff: When building a synthetic diff in Differential, adjust diff properties correctly (authored by epriestley). · Explain WhyApr 30 2019, 1:51 PM

This revision was automatically updated to reflect the committed changes.

epriestley added an edge: rP6eae75d8f2ff: When building a synthetic diff in Differential, adjust diff properties correctly.

Revision Contents
Changeset List

Path

Size

src/

applications/

differential/

controller/

DifferentialChangesetViewController.php

6 lines

Diff 48850

src/applications/differential/controller/DifferentialChangesetViewController.php

Loading...