Page MenuHomePhabricator

When building a synthetic diff in Differential, adjust diff properties correctly
ClosedPublic

Authored by epriestley on Apr 25 2019, 10:09 PM.

Details

Reviewers
amckinley
Summary

See PHI1218. When rendering "A vs B", we currently show the properties of diff A without modification.

Instead, take properties from the same place we're taking change details.

See T12664 for a followup.

Test Plan
  • In diff A, removed "+x" from a file.
  • In diff B, changed the file but did not remove "+x" from it.
  • Diffed B vs A.
    • Before change: UI incorrectly shows "+x" removed (both sides incorrect, just showing the change from diff A).
    • After change: UI shows 100644 -> null, which is half right.

Diff Detail

Repository
rP Phabricator
Branch
flag1
Lint
Lint OK
Unit
Unit Tests OK
Build Status
Buildable 22725
Build 31152: Run Core Tests
Build 31151: arc lint + arc unit