Paths

Table of Contentst

Differential D20453

Improve timeline rendering for old macros
ClosedPublic
Actions

Authored by amckinley on Apr 19 2019, 12:17 AM.

Tags

None

Referenced Files

	F13209624: D20453.diff
	Fri, May 17, 1:12 AM

	Unknown Object (File)
	Tue, May 7, 5:46 PM

	Unknown Object (File)
	Thu, May 2, 4:38 PM

	Unknown Object (File)
	Thu, Apr 25, 7:20 AM

	Unknown Object (File)
	Mar 19 2024, 3:16 PM

	Unknown Object (File)
	Feb 2 2024, 10:37 PM

	Unknown Object (File)
	Jan 19 2024, 5:40 PM

	Unknown Object (File)
	Jan 15 2024, 5:13 PM

View All 54 Files

Subscribers

Korvin

Details

Reviewers

epriestley

Commits

rPde743326394b: Improve timeline rendering for old macros

Summary

This always bugs me when I'm going through secure looking for the spiciest macros.

Test Plan

Forced a date to be null, saw reasonable text.

Diff Detail

Repository

rP Phabricator

Branch

master

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 22675
Build 31074: Run Core Tests
Build 31073: arc lint + arc unit

Event Timeline

amckinley created this revision.Apr 19 2019, 12:17 AM

Harbormaster completed remote builds in B22675: Diff 48804.Apr 19 2019, 12:19 AM

amckinley requested review of this revision.Apr 19 2019, 12:19 AM

Herald added a subscriber: Korvin. · View Herald TranscriptApr 19 2019, 12:19 AM

epriestley accepted this revision.Apr 19 2019, 1:12 AM

This revision is now accepted and ready to land.Apr 19 2019, 1:12 AM

Closed by commit rPde743326394b: Improve timeline rendering for old macros (authored by amckinley). · Explain WhyApr 19 2019, 1:25 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

macro/

controller/

PhabricatorMacroViewController.php

7 lines

Diff 48804

View Options

src/applications/macro/controller/PhabricatorMacroViewController.php

Improve timeline rendering for old macrosClosedPublicActions