Paths

Table of Contentst

Differential D20453

Improve timeline rendering for old macros
ClosedPublic
Actions

Authored by amckinley on Apr 19 2019, 12:17 AM.

Tags

None

Referenced Files

	F18464734: D20453.diff
	Tue, Sep 2, 5:22 AM

	F18409839: D20453.diff
	Sat, Aug 30, 4:20 AM

	F18109777: D20453.id48806.diff
	Mon, Aug 11, 3:17 PM

	F18109752: D20453.id.diff
	Mon, Aug 11, 3:15 PM

	F18103985: D20453.diff
	Sun, Aug 10, 9:04 AM

	F18102738: D20453.id48804.diff
	Sat, Aug 9, 11:03 PM

	F17772959: D20453.id48806.diff
	Jul 23 2025, 4:48 PM

	F17712016: D20453.diff
	Jul 17 2025, 9:22 AM

View All Files

Subscribers

Korvin

Details

Reviewers

epriestley

Commits

rPde743326394b: Improve timeline rendering for old macros

Summary

This always bugs me when I'm going through secure looking for the spiciest macros.

Test Plan

Forced a date to be null, saw reasonable text.

Diff Detail

Repository

rP Phabricator

Branch

master

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 22675
Build 31074: Run Core Tests
Build 31073: arc lint + arc unit

Event Timeline

amckinley created this revision.Apr 19 2019, 12:17 AM

Harbormaster completed remote builds in B22675: Diff 48804.Apr 19 2019, 12:19 AM

amckinley requested review of this revision.Apr 19 2019, 12:19 AM

Herald added a subscriber: Korvin. · View Herald TranscriptApr 19 2019, 12:19 AM

epriestley accepted this revision.Apr 19 2019, 1:12 AM

This revision is now accepted and ready to land.Apr 19 2019, 1:12 AM

Closed by commit rPde743326394b: Improve timeline rendering for old macros (authored by amckinley). · Explain WhyApr 19 2019, 1:25 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

macro/

controller/

PhabricatorMacroViewController.php

7 lines

Diff 48804

View Options

src/applications/macro/controller/PhabricatorMacroViewController.php

Improve timeline rendering for old macrosClosedPublicActions