Page MenuHomePhabricator
Differential D20416

Improve trigger editor behavior when switching to/from tokenizers
ClosedPublic
Actions

Authored by epriestley on Apr 13 2019, 4:07 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Apr 25, 2:02 AM
Unknown Object (File)
Tue, Apr 23, 3:38 PM
Unknown Object (File)
Sat, Apr 20, 4:44 PM
Unknown Object (File)
Fri, Apr 19, 5:39 PM
Unknown Object (File)
Thu, Apr 18, 10:07 PM
Unknown Object (File)
Thu, Apr 18, 1:03 PM
Unknown Object (File)
Thu, Apr 18, 1:48 AM
Unknown Object (File)
Sat, Apr 6, 10:26 AM
View All Files
Subscribers
None

Details

Reviewers
amckinley
Maniphest Tasks
T13269: Improve initial implementations of Workboard triggers and groups
Commits
rP9532bfbb32c8: Improve trigger editor behavior when switching to/from tokenizers
Summary

Ref T13269. See D20329. When we switch trigger rule control types, reset the rule value.

Also, pick slightly nicer defaults for status/priority.

Test Plan
  • Created a "Change Status To: X" rule.
  • Saved it.
  • Edited it.
  • Selected "Assign to" for the existing action's dropdown.
  • Before: tokenizer filled with nonsense.
  • After: tokenizer cleared.

Diff Detail

Repository
rP Phabricator
Branch
trigger1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 22580
Build 30932: Run Core Tests
Build 30931: arc lint + arc unit

Revision Contents
Changeset List

PathSize
resources/
celerity/
src/
applications/
project/
trigger/
2 lines
2 lines
webroot/
rsrc/
js/
application/
trigger/
19 lines

Diff 48710

View Options

resources/celerity/map.php

Loading...
View Options

src/applications/project/trigger/PhabricatorProjectTriggerManiphestPriorityRule.php

Loading...
View Options

src/applications/project/trigger/PhabricatorProjectTriggerManiphestStatusRule.php

Loading...
View Options

webroot/rsrc/js/application/trigger/TriggerRule.js

Loading...
Phabricator · Built by Phacility