Page MenuHomePhabricator

Improve trigger editor behavior when switching to/from tokenizers
ClosedPublic

Authored by epriestley on Apr 13 2019, 4:07 PM.

Details

Summary

Ref T13269. See D20329. When we switch trigger rule control types, reset the rule value.

Also, pick slightly nicer defaults for status/priority.

Test Plan
  • Created a "Change Status To: X" rule.
  • Saved it.
  • Edited it.
  • Selected "Assign to" for the existing action's dropdown.
  • Before: tokenizer filled with nonsense.
  • After: tokenizer cleared.

Diff Detail

Repository
rP Phabricator
Branch
trigger1
Lint
Lint OK
Unit
Unit Tests OK
Build Status
Buildable 22580
Build 30932: Run Core Tests
Build 30931: arc lint + arc unit

Event Timeline

epriestley created this revision.Apr 13 2019, 4:07 PM
epriestley requested review of this revision.Apr 13 2019, 4:09 PM
amckinley accepted this revision.Apr 17 2019, 6:03 PM
This revision is now accepted and ready to land.Apr 17 2019, 6:03 PM
This revision was automatically updated to reflect the committed changes.