Paths

Table of Contentst

Differential D20399

On panel pages, show where panels are used
ClosedPublic
Actions

Authored by epriestley on Apr 11 2019, 7:02 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Thu, Dec 19, 7:02 PM

	Unknown Object (File)
	Tue, Dec 17, 1:29 PM

	Unknown Object (File)
	Thu, Dec 12, 10:47 PM

	Unknown Object (File)
	Fri, Dec 6, 11:18 AM

	Unknown Object (File)
	Tue, Nov 26, 3:49 PM

	Unknown Object (File)
	Tue, Nov 26, 7:17 AM

	Unknown Object (File)
	Tue, Nov 26, 6:18 AM

	Unknown Object (File)
	Tue, Nov 26, 6:18 AM

Subscribers

None

Details

Reviewers

Maniphest Tasks

T6018: Panels used by Tab panels appear as "This panel does not appear on any dashboards."
T13272: Remove the hard-coded homepage, and other Dashboards improvements

Commits

rP51f2ed498dbf: On panel pages, show where panels are used

Summary

Depends on D20398. Ref T13272. Fixes T6018. Previously, panels showed "used on dashboards: x, y", but this did not include cases where a panel was used by another container panel (today, a tab panel).

Do edge indexing when a dashboard or panel is saved, then pull the edges on the Panel page so we can provide a full list of uses.

Test Plan

Screen Shot 2019-04-11 at 11.54.17 AM.png (317×1 px, 38 KB)

Diff Detail

Repository

Branch

panel4

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 22551
Build 30883: Run Core Tests
Build 30882: arc lint + arc unit

Event Timeline

epriestley created this revision.Apr 11 2019, 7:02 PM

Harbormaster completed remote builds in B22551: Diff 48678.Apr 11 2019, 7:04 PM

epriestley requested review of this revision.Apr 11 2019, 7:04 PM

epriestley added a child revision: D20402: Modularize Dashboard transactions.Apr 11 2019, 9:01 PM

amckinley accepted this revision.Apr 11 2019, 9:54 PM

amckinley added inline comments.

src/applications/dashboard/interface/PhabricatorDashboardPanelContainerInterface.php
3	Was this supposed to get an interface implementation template? I guess it's only ever going to have the two implementors in this diff...
src/applications/dashboard/query/PhabricatorDashboardPanelQuery.php
105	Intentional? At least in my DB, the table looks like `local_dashboard.dashboard_panel`.

This revision is now accepted and ready to land.Apr 11 2019, 9:54 PM

epriestley added inline comments.Apr 11 2019, 9:57 PM

src/applications/dashboard/query/PhabricatorDashboardPanelQuery.php
105	We `SELECT * FROM dashboard_panel AS <this alias>` in query construction, so it can be anything, as long as the rest of the query uses the same string. It's mostly so when we join we can disambiguate between various `id`, `phid`, `dateCreated`, etc., columns. I was initially adding a JOIN here but didn't need it, but kept the alias change since it's more consistent with other queries.

amckinley added inline comments.Apr 11 2019, 9:58 PM

src/applications/dashboard/query/PhabricatorDashboardPanelQuery.php
105	Ahhh that makes more sense.

epriestley added inline comments.Apr 11 2019, 9:59 PM

src/applications/dashboard/interface/PhabricatorDashboardPanelContainerInterface.php
3	(And, yeah, this one was "we probably only ever have two of these, I hope".)

Closed by commit rP51f2ed498dbf: On panel pages, show where panels are used (authored by epriestley). · Explain WhyApr 12 2019, 1:14 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

resources/

celerity/

src/

__phutil_library_map__.php

applications/

dashboard/

controller/

dashboard/

PhabricatorDashboardViewController.php

2 lines

panel/

PhabricatorDashboardPanelViewController.php

50 lines

editor/

PhabricatorDashboardPanelTransactionEditor.php

4 lines

PhabricatorDashboardTransactionEditor.php

3 lines

engineextension/

PhabricatorDashboardPanelContainerIndexEngineExtension.php

28 lines

interface/

PhabricatorDashboardPanelContainerInterface.php

12 lines

paneltype/

PhabricatorDashboardPanelType.php

4 lines

PhabricatorDashboardTabsPanelType.php

22 lines

phid/

PhabricatorDashboardPanelPHIDType.php

8 lines

query/

PhabricatorDashboardPanelQuery.php

12 lines

storage/

PhabricatorDashboard.php

11 lines

PhabricatorDashboardPanel.php

9 lines

search/

edge/

PhabricatorDashboardPanelUsedByObjectEdgeType.php

16 lines

PhabricatorObjectUsesDashboardPanelEdgeType.php

16 lines

webroot/

rsrc/

css/

aphront/

3 lines

Diff 48678

resources/celerity/map.php

Loading...

src/__phutil_library_map__.php

Loading...

src/applications/dashboard/controller/dashboard/PhabricatorDashboardViewController.php

Loading...

src/applications/dashboard/controller/panel/PhabricatorDashboardPanelViewController.php

Loading...

src/applications/dashboard/editor/PhabricatorDashboardPanelTransactionEditor.php

Loading...

src/applications/dashboard/editor/PhabricatorDashboardTransactionEditor.php

Loading...

src/applications/dashboard/engineextension/PhabricatorDashboardPanelContainerIndexEngineExtension.php

Loading...

src/applications/dashboard/interface/PhabricatorDashboardPanelContainerInterface.php

Loading...

src/applications/dashboard/paneltype/PhabricatorDashboardPanelType.php

Loading...

src/applications/dashboard/paneltype/PhabricatorDashboardTabsPanelType.php

Loading...

src/applications/dashboard/phid/PhabricatorDashboardPanelPHIDType.php

Loading...

src/applications/dashboard/query/PhabricatorDashboardPanelQuery.php

Loading...

src/applications/dashboard/storage/PhabricatorDashboard.php

Loading...

src/applications/dashboard/storage/PhabricatorDashboardPanel.php

Loading...

src/applications/search/edge/PhabricatorDashboardPanelUsedByObjectEdgeType.php

Loading...

src/applications/search/edge/PhabricatorObjectUsesDashboardPanelEdgeType.php

Loading...

webroot/rsrc/css/aphront/table-view.css

Loading...