Page MenuHomePhabricator

Correct some straggling Ferret/Cursor interactions
ClosedPublic

Authored by epriestley on Mar 30 2019, 9:38 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Feb 9, 1:27 PM
Unknown Object (File)
Sun, Feb 9, 7:31 AM
Unknown Object (File)
Sun, Feb 9, 7:31 AM
Unknown Object (File)
Sun, Feb 9, 7:31 AM
Unknown Object (File)
Sun, Feb 9, 7:31 AM
Unknown Object (File)
Thu, Feb 6, 12:50 PM
Unknown Object (File)
Tue, Jan 28, 12:55 PM
Unknown Object (File)
Sat, Jan 25, 8:45 AM
Subscribers
None

Details

Summary

See PHI1182. Ref T13266. The recent fixes didn't quite cover the case where you have a query, but order by something other than relevance, and page forward.

Refine the tests around building/selecting these columns and paging values a little bit to be more specific about what they care about.

Test Plan

Executed queries, then went to "Next Page", for:

  • query text, non-relevance order.
  • query text, relevance order.
  • no query text, non-relevance order.
  • no query text, relevance order.

Also, made an API call similar to the one in PHI1182.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable