Page MenuHomePhabricator

Correct some straggling Ferret/Cursor interactions
ClosedPublic

Authored by epriestley on Mar 30 2019, 9:38 PM.
Tags
None
Referenced Files
F13095900: D20354.diff
Thu, Apr 25, 1:21 PM
Unknown Object (File)
Sat, Apr 20, 4:42 PM
Unknown Object (File)
Fri, Apr 19, 5:50 AM
Unknown Object (File)
Thu, Apr 11, 9:41 AM
Unknown Object (File)
Wed, Apr 3, 8:25 AM
Unknown Object (File)
Mon, Apr 1, 3:43 AM
Unknown Object (File)
Mar 25 2024, 7:44 AM
Unknown Object (File)
Mar 25 2024, 7:44 AM
Subscribers
None

Details

Summary

See PHI1182. Ref T13266. The recent fixes didn't quite cover the case where you have a query, but order by something other than relevance, and page forward.

Refine the tests around building/selecting these columns and paging values a little bit to be more specific about what they care about.

Test Plan

Executed queries, then went to "Next Page", for:

  • query text, non-relevance order.
  • query text, relevance order.
  • no query text, non-relevance order.
  • no query text, relevance order.

Also, made an API call similar to the one in PHI1182.

Diff Detail

Repository
rP Phabricator
Branch
cursor1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 22444
Build 30717: Run Core Tests
Build 30716: arc lint + arc unit