Page MenuHomePhabricator

Hide "Availability" and "Calendar" on user profiles for disabled users
ClosedPublic

Authored by epriestley on Mar 28 2019, 11:26 PM.
Tags
None
Referenced Files
F14646193: D20342.id48549.diff
Sat, Jan 11, 10:50 AM
Unknown Object (File)
Wed, Jan 1, 7:27 AM
Unknown Object (File)
Tue, Dec 31, 9:54 PM
Unknown Object (File)
Thu, Dec 26, 7:52 PM
Unknown Object (File)
Dec 12 2024, 5:59 AM
Unknown Object (File)
Dec 9 2024, 7:15 AM
Unknown Object (File)
Dec 7 2024, 10:46 AM
Unknown Object (File)
Nov 26 2024, 6:26 AM
Subscribers
None

Details

Summary

See downstream https://phabricator.wikimedia.org/T138723. That suggestion is a little light on details, but I basically agree that showing "Availability: Available" on disabled user profiles is kind of questionable/misleading.

Just hide event information on disabled profiles, since this doesn't seem worth building a special "Availability: Who Knows, They Are Disabled, Good Luck" disabled state for.

Test Plan

Looked at disabled and non-disabled user profiles, saw Calendar stuff only on the former.

Diff Detail

Repository
rP Phabricator
Branch
avail1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 22420
Build 30678: Run Core Tests
Build 30677: arc lint + arc unit