Page MenuHomePhabricator

Hide "Availability" and "Calendar" on user profiles for disabled users
ClosedPublic

Authored by epriestley on Mar 28 2019, 11:26 PM.
Tags
None
Referenced Files
F14796896: D20342.id48553.diff
Sat, Jan 25, 4:28 AM
F14796894: D20342.id48549.diff
Sat, Jan 25, 4:28 AM
F14796893: D20342.id.diff
Sat, Jan 25, 4:27 AM
F14796890: D20342.diff
Sat, Jan 25, 4:27 AM
Unknown Object (File)
Fri, Jan 17, 2:03 PM
Unknown Object (File)
Thu, Jan 16, 11:03 PM
Unknown Object (File)
Sat, Jan 11, 10:50 AM
Unknown Object (File)
Wed, Jan 1, 7:27 AM
Subscribers
None

Details

Summary

See downstream https://phabricator.wikimedia.org/T138723. That suggestion is a little light on details, but I basically agree that showing "Availability: Available" on disabled user profiles is kind of questionable/misleading.

Just hide event information on disabled profiles, since this doesn't seem worth building a special "Availability: Who Knows, They Are Disabled, Good Luck" disabled state for.

Test Plan

Looked at disabled and non-disabled user profiles, saw Calendar stuff only on the former.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable