Page MenuHomePhabricator

Fix content overflow in user hovercards

Authored by epriestley on Mar 29 2019, 12:21 AM.
Referenced Files
Unknown Object (File)
Sat, Nov 25, 9:26 PM
Unknown Object (File)
Wed, Nov 15, 4:14 AM
Unknown Object (File)
Wed, Nov 1, 1:53 PM
Unknown Object (File)
Oct 24 2023, 11:02 AM
Unknown Object (File)
Oct 6 2023, 8:37 AM
Unknown Object (File)
Oct 6 2023, 8:36 AM
Unknown Object (File)
Oct 6 2023, 8:36 AM
Unknown Object (File)
Sep 23 2023, 12:02 AM



Fixes T13273. This element is a bit weird, but I think I fixed it without breaking anything.

The CSS is used by project hovercards and user hovercards, but they each have a class which builds mostly-shared-but-not-really-identical CSS, instead of having a single View class with modes. So I'm not 100% sure I didn't break something obscure, but I couldn't find anything this breaks.

The major issue is that all the text content has "position: absolute". Instead, make the image "absolute" and the text actual positioned content. Then fix all the margins/padding/spacing/layout and add overflow. Seems to work?

Plus: hide availability for disabled users, for consistency with D20342.

Test Plan


Screen Shot 2019-03-28 at 5.13.25 PM.png (373×1 px, 74 KB)


Screen Shot 2019-03-28 at 5.13.19 PM.png (315×479 px, 38 KB)

I think this is pixel-exact except for the overflow behavior.


  • Viewed some other user hovercards, including a disabled user. They all looked unchanged.
  • Viewed some project hovercards. They all looked good, too.

Diff Detail

rP Phabricator
Lint Not Applicable
Tests Not Applicable

Event Timeline

This revision is now accepted and ready to land.Mar 29 2019, 3:24 AM
This revision was automatically updated to reflect the committed changes.