Page MenuHomePhabricator

Fix task hovercards showing a "Not Editable" state
ClosedPublic

Authored by epriestley on Mar 26 2019, 10:47 PM.
Tags
None
Referenced Files
F19150951: D20330.diff
Dec 10 2025, 9:49 PM
F19132421: D20330.diff
Dec 10 2025, 6:15 AM
F19131099: D20330.diff
Dec 10 2025, 5:50 AM
F19109240: D20330.diff
Dec 8 2025, 10:25 PM
F19059057: D20330.id.diff
Nov 29 2025, 4:12 AM
F19053473: D20330.diff
Nov 28 2025, 8:55 AM
F18852778: D20330.diff
Oct 31 2025, 11:50 AM
F18829511: D20330.diff
Oct 24 2025, 10:35 PM
Subscribers
None

Details

Summary

Ref T13269. These cards really have three states:

  • Editable: shows a pencil icon edit button.
  • You Do Not Have Permission To Edit This: shows a "no editing" icon in red.
  • Hovecard: shouldn't show anything.

However, the "hovercard" and "no permission" states are currently the same state, so when I made the "no permission" state more obvious that made the hovercard go all weird.

Make these states explicitly separate states.

Test Plan

Looked at a...

  • Editable card on workboard: edit state.
  • No permission card on workboard: no permission state.
  • Any hovercard: "not editable, this is a hovercard" state.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable